feat: add support for cors and integrate waku-frontend #30
Conversation
|
@gabrielmer do we need to use custom nwaku image or latest to have the fix for cors? |
| @@ -86,6 +86,7 @@ exec /usr/bin/wakunode\ | |||
| --rest=true\ | |||
| --rest-address=0.0.0.0\ | |||
| --rest-port=8645\ | |||
| --rest-allow-origin:"localhost:*"\ | |||
There was a problem hiding this comment.
mm, is this flag an nwaku flag? can't find it.
There was a problem hiding this comment.
This flag is going to be introduced and is not yet merged to master. We need to first merge a PR in nim-presto in order to create the PR in nwaku that would introduce this flag.
I built a custom image that includes the changes in nwaku and in nim-presto so we can use in the meantime, and in that image that flag is defined.
So if we want to use that flag, we need to also modify the image used by nwaku.
To have the fix for CORS we currently need the custom image If necessary I can create an image with a more meaningful/appropriate name |
|
This PR should be ready now. |
There was a problem hiding this comment.
LGTM until we get the CORS fix into master. @alrevuelta what do you think?
| # TODO: migrate to waku-org | ||
| image: docker.io/alrevuelta/waku-frontend:latest | ||
| ports: | ||
| - 127.0.0.1:8080:80 |
There was a problem hiding this comment.
if the frontend listens on 3000, shouldnt this be
127.0.0.1:8080:3000
Accepting connections at http://localhost:3000
I would prefer to wait until we have the cors issue fixed in a release, unless this blocks something else. |
Fine by me, just to clarify - Chat is not working without it |
|
Morning @weboko ! I think this can be closed now given that we currently supporting the frontend |
|
@weboko confirmed that we can close that one. Thanks for it 🙌 ! |
No description provided.