Fix ip colocation limit

waku-org · Jan 9, 2024 · d523505 · d523505
1 parent d830ffb
commit d523505
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/waku/node/peer_manager/peer_manager.nim b/waku/node/peer_manager/peer_manager.nim
@@ -386,11 +386,12 @@ proc onPeerEvent(pm: PeerManager, peerId: PeerId, event: PeerEvent) {.async.} =
         # in theory this should always be one, but just in case
         let peersBehindIp = pm.ipTable[ip.get]
 
-        let idx = max((peersBehindIp.len - pm.colocationLimit), 0)
-        for peerId in peersBehindIp[0..<idx]:
-          debug "Pruning connection due to ip colocation", peerId = peerId, ip = ip
-          asyncSpawn(pm.switch.disconnect(peerId))
-          pm.peerStore.delete(peerId)
+        # pm.colocationLimit == 0 disables the ip colocation limit
+        if pm.colocationLimit != 0 and peersBehindIp.len > pm.colocationLimit:
+          for peerId in peersBehindIp[0..<(peersBehindIp.len - pm.colocationLimit)]:
+            debug "Pruning connection due to ip colocation", peerId = peerId, ip = ip
+            asyncSpawn(pm.switch.disconnect(peerId))
+            pm.peerStore.delete(peerId)
     of Left:
       direction = UnknownDirection
       connectedness = CanConnect