Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (postgres): Protect the nwaku compilation process so that the user has the libpq library properly installed. #1839

Closed
Ivansete-status opened this issue Jul 5, 2023 · 1 comment

Comments

@Ivansete-status
Copy link
Collaborator

Background

By adding support to Postgres we've also added a dependency with the "libpq.5.so" (name on Ubuntu) library.

Details

We will add some hints in the https://docs.waku.org/ page (waku-org/docs.waku.org#78) so that the user is informed about the Postgres pre-requisite.

However, we need to enhance the ux regarding the compilation process. Therefore, we need to apply either of these:

  • Avoid running the postgres-dependant modules unless the user wants to explicitly use Postgres. For that we might do sth analog to rln (when defined(rln):.) <--- This is the preferable approach.
  • Have the postgres library integrated in a similar way the sqlite library is.

Related issue

#1604

@Ivansete-status
Copy link
Collaborator Author

I'm closing because we added the POSTGRES compilation flag that should explicitly be set if the user is willing to interact with Postgres

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants