Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim-waku external files and resources #798

Closed
2 tasks
jm-clius opened this issue Dec 8, 2021 · 1 comment
Closed
2 tasks

nim-waku external files and resources #798

jm-clius opened this issue Dec 8, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jm-clius
Copy link
Contributor

jm-clius commented Dec 8, 2021

Problem

In some places nim-waku code references versioned controlled files/resources in an ad-hoc manner. For example, migration loads migrations scripts from the source code directory, while RLN references a file in the /vendor/ subdirectory. These are sometimes added, sometimes not, to the docker image, leading to bugs and inconsistencies.

Solution

Proper resources management, with all resources being made available in a resources/ subdirectory that is always included in the docker image and PATH.

Acceptance criteria

  • External resources for wakunode2 (including for RLN) all reside in a single place.
  • Docker image updated to reference this path
@jm-clius
Copy link
Contributor Author

Closing. RLN can now be statically compiled. Migration scripts are being moved to external process by DB operator. Similar issue with postgresql dependency being addressed here: #1839

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

1 participant