Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(migrations): move migration scripts to project root #1330

Merged
merged 1 commit into from
Nov 3, 2022
Merged

chore(migrations): move migration scripts to project root #1330

merged 1 commit into from
Nov 3, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 2, 2022

Following the spirit of #1325 and aligned with #798:

As an intermediate step, I decided to do a minor cleanup before we make another decision about what to do with the SQLite migrations.

  • Move the SQLite database migration scripts outside the project code. Move them to the migrations directory in the project root
  • Update the script's path to the new location

@LNSD LNSD requested a review from jm-clius November 2, 2022 16:52
@LNSD LNSD self-assigned this Nov 2, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 2, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b17fc66 #1 2022-11-02 23:03:10 ~16 min macos 📦bin
✔️ a5189e0 #1 2022-11-03 10:34:39 ~17 min linux 📦bin
❌ a5189e0 #2 2022-11-03 10:43:07 ~26 min macos 📄log
✔️ a5189e0 #3 2022-11-03 11:42:41 ~20 min macos 📦bin

@LNSD LNSD force-pushed the refactor-sqlite-scripts branch from b17fc66 to a5189e0 Compare November 3, 2022 10:16
jm-clius
jm-clius approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LNSD LNSD merged commit 27a7040 into master Nov 3, 2022
@LNSD LNSD deleted the refactor-sqlite-scripts branch November 3, 2022 16:58
jakubgs added a commit that referenced this pull request Nov 4, 2022
@jakubgs
ci: fix path to migrations in Dockerfile
3c8fab7 
Broken by moving the `migrations_scripts` folder:
#1330

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs mentioned this pull request Nov 4, 2022
Merged
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

Assignees

@LNSD LNSD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @status-im-auto @jm-clius