Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(REST): returning lightpush support and updated filter protocol #2219

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Nov 15, 2023

Description

For /admin/v1/peers endpoint, add to response Lightpush and Filter v2 capabilities and connection status of peers.

Will remove legacy Filter data from the response once it gets officially deprecated.

Changes

  • Adding to the response Lightpush capability and connection status of peers
  • Adding to the response Filter v2 capability and connection status of peers

After fix, response looks the following way:
image

Issue

closes #2220

@gabrielmer gabrielmer changed the title enhancement(REST API): returning lightpush support and updated filter protocol chore(REST API): returning lightpush support and updated filter protocol Nov 15, 2023
@gabrielmer gabrielmer changed the title chore(REST API): returning lightpush support and updated filter protocol chore(REST): returning lightpush support and updated filter protocol Nov 15, 2023
@gabrielmer gabrielmer self-assigned this Nov 15, 2023
Copy link

github-actions bot commented Nov 15, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2219

Built from 82d0960

@gabrielmer gabrielmer marked this pull request as ready for review November 16, 2023 15:56
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful! Thanks.

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@gabrielmer gabrielmer merged commit 59ee3c6 into master Nov 22, 2023
9 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-improving-get-peers-rest branch November 22, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(REST): adding to /admin/v1/peers response lightpush and filter v2 peer info
3 participants