Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing automatic vacuuming from retention policy code #2228

Merged
merged 4 commits into from
Nov 21, 2023
Merged

chore: removing automatic vacuuming from retention policy code #2228

merged 4 commits into from
Nov 21, 2023

Conversation

ABresting
Copy link
Contributor

Description

As discussed in #2226, the automatic vacuuming is removed from the retention policy code.

Changes

  • vacuuming code removed from retention policy
  • associated testcase updated

Issue

closes #2226

@ABresting ABresting self-assigned this Nov 17, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2228

Built from b032bcb

SionoiS
SionoiS approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

waku/waku_archive/retention_policy/retention_policy_size.nim Outdated Show resolved Hide resolved
waku/waku_archive/retention_policy/retention_policy_size.nim Outdated Show resolved Hide resolved
@ABresting ABresting merged commit 9ff441a into master Nov 21, 2023
2 checks passed
@ABresting ABresting deleted the remove-vacuuming-in-retention-policy branch November 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

@jm-clius jm-clius Awaiting requested review from jm-clius

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@ABresting ABresting

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: removing the vacuuming process from capacity and size retention policy
3 participants
@ABresting @richard-ramos @SionoiS