Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid blocking the whole waku node when retention policy is being applied #2238

Closed
Ivansete-status opened this issue Nov 23, 2023 · 1 comment · Fixed by #2278
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Ivansete-status
Copy link
Collaborator

Background

The retention policy logic makes a very first check when the nwaku node is starting. However, the waitFor statement is being used for such initial message reduction, which therefore makes the whole node get blocked until the removal is completed.

That happens in

let retPolRes = waitFor node.wakuArchive.executeMessageRetentionPolicy()

Note: Aside from that, I noticed that, in a database with 16Million rows and a retention policy of 12Milion rows, the actual execution got stuck the whole night, it is worth checking whether the rows-removal works well. That happened in Postgres.

Acceptance criteria

The application of the retention policy should never block the nwaku node.

@chair28980 chair28980 added the enhancement New feature or request label Nov 28, 2023
@chair28980 chair28980 moved this to To Do in Waku Nov 28, 2023
@Ivansete-status Ivansete-status moved this from To Do to In Progress in Waku Dec 8, 2023
@Ivansete-status Ivansete-status self-assigned this Dec 8, 2023
@Ivansete-status
Copy link
Collaborator Author

Weekly Update

  • achieved: avoid blocking the whole waku node when the retention policy is being applied

@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants