fix: archive - simplify and enhance async retention policy application #2278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that made the whole
wakunode2
to get stuck when applying the retention policy at the beginning of the execution. That happened because we usedwaitFor
which blocks everything until the task end.With that PR, we perform a better retention policy application approach, i.e. a fully asynchronous task that can be canceled anytime. We also simplify the approach by avoiding using a "timer".
Changes
How to test
Test case 1
Test case 2
Issue
closes #2238