Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: store v3 include data is ignored #2635

Closed
SionoiS opened this issue Apr 25, 2024 · 0 comments · Fixed by #2636
Closed

bug: store v3 include data is ignored #2635

SionoiS opened this issue Apr 25, 2024 · 0 comments · Fixed by #2636
Assignees
Labels
bug Something isn't working

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Apr 25, 2024

Found by @richard-ramos. noted here for tracking

Request

{"request_id":"5ce5c3b70adcfcd377f7281e0a8d80b6195c2b0b86c36d0b7316c074cdc1c6e7","message_hashes":["h6StC5Lp/RaZQOqJt6iSVozZFf6kTNkBvKkGUw79pIE=","0PlMki3ca7EsffDqRj4tq2MDfovfMQXKzfF6KeqeiMs=","2lRlED6pw9DFzxPmagfFt6GAXz9Z+plv3yfwTymbEvI=","NGs/hR2QL12oNc+tgKnitp2ebQO1HDoO8bUVCjrYqZI=","pryd3GuG9Lc+bKvI5qTbc1AF9YUMrFyjBoiRkY0QZmY=","PJATgU/Gz6IlJ7nM31ac0FfcjGZNKh2YEIdhHBotCLU=","QMebdkTuKkGICmbKXReUobvWWZwT30YqmTZ3sBj6XOo=","Ow9Rn4VdTbZS0aFOArn8IiGxImGl3YZsCIXGjadIOWo=","9CHgfcvlGRF8CAP1thvZI056ciIkdBVlFBPWtBBkVtQ=","fjagI+m3+xwbpgHZLSJ2fvsessRLJLyo+iGkbvGyZYc="],"pagination_forward":true,"pagination_limit":20}

Response

{"request_id":"5ce5c3b70adcfcd377f7281e0a8d80b6195c2b0b86c36d0b7316c074cdc1c6e7","status_code":200,"status_desc":"OK","messages":[{"message_hash":"h6StC5Lp/RaZQOqJt6iSVozZFf6kTNkBvKkGUw79pIE=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806896399058","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"0PlMki3ca7EsffDqRj4tq2MDfovfMQXKzfF6KeqeiMs=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806917331304","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"2lRlED6pw9DFzxPmagfFt6GAXz9Z+plv3yfwTymbEvI=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806937900393","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"NGs/hR2QL12oNc+tgKnitp2ebQO1HDoO8bUVCjrYqZI=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806958300525","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"pryd3GuG9Lc+bKvI5qTbc1AF9YUMrFyjBoiRkY0QZmY=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806978588237","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"PJATgU/Gz6IlJ7nM31ac0FfcjGZNKh2YEIdhHBotCLU=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057806999078482","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"QMebdkTuKkGICmbKXReUobvWWZwT30YqmTZ3sBj6XOo=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057807019396660","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"Ow9Rn4VdTbZS0aFOArn8IiGxImGl3YZsCIXGjadIOWo=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057807039695032","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"9CHgfcvlGRF8CAP1thvZI056ciIkdBVlFBPWtBBkVtQ=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057807060040999","meta":"","ephemeral":false,"rateLimitProof":""}},{"message_hash":"fjagI+m3+xwbpgHZLSJ2fvsessRLJLyo+iGkbvGyZYc=","message":{"payload":"AQIDBAU=","contentTopic":"test","version":0,"timestamp":"1714057807080564052","meta":"","ephemeral":false,"rateLimitProof":""}}]}

The include data field is omitted in the request BUT the message is still returned.

@SionoiS SionoiS added the bug Something isn't working label Apr 25, 2024
@SionoiS SionoiS self-assigned this Apr 25, 2024
@SionoiS SionoiS changed the title bug: store v3 bug: store v3 include data is ignored Apr 25, 2024
@gabrielmer gabrielmer moved this to To Do in Waku Apr 26, 2024
@SionoiS SionoiS moved this from To Do to In Progress in Waku Apr 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant