feat: storeV3 client #1028
Merged
feat: storeV3 client #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-ramos
commented
Feb 7, 2024
•
richard-ramos
commented
- Use waku-proto protobuffer (once available)
- Implement queryFrom
- TODOs
- Test units
- Interop against nwaku
- Github action to test this feature automatically against nwaku
Jenkins BuildsClick to see older builds (28)
|
|
Just few items missing: the validation of response codes and interop tests against waku-org/nwaku#2431 once available. |
richard-ramos
force-pushed
the
store-v3
branch
2 times, most recently
from
b30f5c5
to
29c0184
Compare
|
Some issues were identified during interop with nwaku:
Also, the protobuffer used in this PR uses different variable type compared to the spec vacp2p/rfc#665 . I do believe that the implementation in nwaku and go-waku is what should be used tho. |
richard-ramos
force-pushed
the
store-v3
branch
17 times, most recently
from
5abca34
to
5590bda
Compare
richard-ramos
force-pushed
the
store-v3
branch
4 times, most recently
from
6993120
to
01fc9de
Compare
|
@chaitanyaprem This PR is ready to review! Btw, this is like 1500 lines PR, but fear not! It's because i renamed a package from |
chaitanyaprem
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.