Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate support for named sharding: #2772

Closed
2 tasks
gabrielmer opened this issue Jun 4, 2024 · 0 comments · Fixed by #2723
Closed
2 tasks

chore: deprecate support for named sharding: #2772

gabrielmer opened this issue Jun 4, 2024 · 0 comments · Fixed by #2723
Assignees
@gabrielmer
Labels
effort/weeks Estimated to be completed in a few weeks
Milestone
v0.31.0

Comments

@gabrielmer
Copy link
Contributor

gabrielmer commented Jun 4, 2024 •
edited
Loading

Background

Deprecate Support for Named Sharding:
It is recommended to remove support for named sharding.
Peer management should ensure that only peers supporting sharded topics are connected.

Acceptance criteria

  • Named sharding should not be accepted anymore.
  • --pubsub-topic CLI config should be deprecated in favor of --cluster-id and --shard
@gabrielmer gabrielmer changed the title chore: Deprecate Support for Named Sharding: chore: deprecate Support for Named Sharding: Jun 4, 2024
@gabrielmer gabrielmer added the effort/weeks Estimated to be completed in a few weeks label Jun 4, 2024
@gabrielmer gabrielmer changed the title chore: deprecate Support for Named Sharding: chore: deprecate support for named sharding: Jun 4, 2024
@gabrielmer gabrielmer self-assigned this Jun 4, 2024
@gabrielmer gabrielmer moved this to In Progress in Waku Jun 4, 2024
@gabrielmer gabrielmer mentioned this issue Jun 4, 2024
Closed
4 tasks
@Ivansete-status Ivansete-status added this to the v0.31.0 milestone Jun 12, 2024
@gabrielmer gabrielmer mentioned this issue Jun 12, 2024
Merged
@gabrielmer gabrielmer moved this from In Progress to Blocked in Waku Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Waku Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielmer gabrielmer

Labels
effort/weeks Estimated to be completed in a few weeks
Projects
Waku
Archived in project
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

chore: deprecating named sharding waku-org/nwaku
2 participants
@gabrielmer @Ivansete-status