Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lightpush client API #2774

Open
2 tasks
gabrielmer opened this issue Jun 4, 2024 · 3 comments
Open
2 tasks

chore: update lightpush client API #2774

gabrielmer opened this issue Jun 4, 2024 · 3 comments
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@gabrielmer
Copy link
Contributor

gabrielmer commented Jun 4, 2024

Background

To maintain adherence to the sharded format, the lightpush client API should be updated.
New proposed format: lightPublish(WakuMessage, ClusterID, ShardNumber)

For legacy requests on named topics, the API could use a trial and error process to send the request to random service nodes.
This can be done using the format: lightPublish(WakuMessage, PubsubTopic)
A request format that bypasses our peer management/selection: lightPublish(WakuMessage, PubsubTopic, ServiceNodeMultiaddr)

Acceptance criteria

  • Introduce the new lightpush client API as mentioned above.
  • Update documentation to reflect these changes and guide users accordingly.
@gabrielmer gabrielmer moved this to To Do in Waku Jun 4, 2024
@gabrielmer gabrielmer added the effort/days Estimated to be completed in a few days, less than a week label Jun 4, 2024
@NagyZoltanPeter
Copy link
Contributor

@gabrielmer Please consider add it to waku-org/specs#20 if necessary and maybe it can be part of waku-org/pm#93

@Ivansete-status WDYT?

@gabrielmer
Copy link
Contributor Author

feat: Deprecate Named Sharding and Update Lightpush Client API #2163

Ooh, thank you! Not sure if this is still relevant, I just separated the 3 points in #2163 into 3 different issues. I agree this should be considered as part of waku-org/pm#93 , whether applied or discarded.

@Ivansete-status
Copy link
Collaborator

@NagyZoltanPeter @gabrielmer - I 💯 agree with you both. Given that we are starting to decommission the pubsub topic concept, I think is great to stick only to the cluster+shards terms :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Status: To Do
Development

No branches or pull requests

3 participants