fix: filter - enhancements in subscription management #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* waku_filter_v2: idiomatic way run periodic subscription manager * filter subscriptions: add more debug logs * filter: make sure the custom start and stop procs are called * make sure filter protocol is started if it is mounted * filter: dial push connection onsubscribe only
Ivansete-status
changed the title
|
You can find the image built from this PR at Built from 9064bb8 |
Ivansete-status
requested review from
NagyZoltanPeter,
richard-ramos,
darshankabariya and
gabrielmer
gabrielmer
approved these changes
Dec 13, 2024
waku/waku_peer_exchange/protocol.nim
Outdated
| waku_px_errors.inc(labelValues = [exc.msg]) | ||
| callResult = ( | ||
| status_code: PeerExchangeResponseStatusCode.SERVICE_UNAVAILABLE, | ||
| status_desc: some($exc.msg), | ||
| ) | ||
| finally: | ||
| debug "JJJJ" |
There was a problem hiding this comment.
We probably need to remove this, although I liked more when we used jamon for random debug logs 😆
waku/waku_peer_exchange/protocol.nim
Outdated
| @@ -272,6 +286,7 @@ proc initProtocolHandler(wpx: WakuPeerExchange) = | |||
| ).isOkOr: | |||
| error "Failed to respond with TOO_MANY_REQUESTS:", error = $error | |||
| # close, no data is expected | |||
| debug "JJJJ" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Railgun notified about filter issues. This PR tackled that.
Railgun informed that after 4 days working properly, the nodes stopped sending messages. There were also issues that caused a max of 100 messages being sent over one connection and the reason for that was that we were
dialPeering on every single message the filter server sent to the filter subscribers.Changes
How to test
Issue
closes #3191
closes #3192