feat(rln-relay): track last seen event #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
track:rln
rymnc
commented
Oct 25, 2022
| # TODO: check the index and the pubkey depending on | ||
| # the group update operation | ||
| var handler: GroupUpdateHandler | ||
| handler = proc(pubkey: Uint256, index: Uint256): RlnRelayResult[void] {.raises: [Defect].} = |
There was a problem hiding this comment.
As part of the member deletion feature, this handler will soon take in an additional argument, GroupUpdateType, which will be either Insertion or Deletion, and then we can handle those cases separately.
Jenkins BuildsClick to see older builds (24)
|
29 tasks
s1fr0
reviewed
Oct 27, 2022
There was a problem hiding this comment.
The PR looks good to me, but I'm still not sure about using the last seen index as indicator. See #1265 (comment).
staheri14
reviewed
Oct 27, 2022
|
|
||
|
|
||
| proc handleGroupUpdates*(rlnPeer: WakuRLNRelay, handler: RegistrationEventHandler) {.async, gcsafe.} = | ||
| proc handleGroupUpdates*(rlnPeer: WakuRLNRelay) {.async, gcsafe.} = | ||
| # mounts the supplied handler for the registration events emitting from the membership contract |
There was a problem hiding this comment.
Do these comments still hold?
| ethAccountAddress: Option[Address] = none(Address), | ||
| contractAddress: Address, | ||
| blockNumber: string = "0x0", | ||
| handler: GroupUpdateHandler) {.async, gcsafe.} = | ||
| ## connects to the eth client whose URI is supplied as `ethClientUri` |
There was a problem hiding this comment.
Please update the proc description to match the new semantics.
| @@ -945,20 +976,25 @@ proc subscribeToGroupEvents(ethClientUri: string, ethAccountAddress: Option[Addr | |||
|
|
|||
| proc startSubscription(web3: Web3) {.async, gcsafe.} = | |||
There was a problem hiding this comment.
Why do we need to have a separate proc for this, why not just call the subscribeToMemberRegistrations proc?
There was a problem hiding this comment.
Eventually, when we have the reconnection logic, it becomes easier to resubscribe to events from the last processed block.
staheri14
approved these changes
Nov 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #1265
Tracks the last seen event and stores it on the WakuRlnRelay instance so that it can be reused in the eth node reconnection feature