fix(peer-exchange): start px discv5 loop after discv5 has started #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
reviewed
Nov 21, 2022
| @@ -489,7 +487,10 @@ proc startNode(node: WakuNode, conf: WakuNodeConf, | |||
| await connectToNodes(node, dynamicBootstrapNodes, "dynamic bootstrap") | |||
| except: | |||
| return err("failed to connect to dynamic bootstrap nodes: " & getCurrentExceptionMsg()) | |||
|
|
|||
|
|
|||
| if conf.peerExchange: | |||
There was a problem hiding this comment.
Just checking. Before we were also running runPeerExchangeDiscv5Loop if conf.peerExchangeNode != "", but not only if conf.peerExchange. Is this intended? :)
There was a problem hiding this comment.
Yes, because only a service node has to run discv5. Nodes that only specify a peer-exchange-node act as client.
(In a future refactor, client nodes should be able to use peer exchange without mounting the protocol.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer exchange discv5 loop was stared before discv5 was listening, causing the loop to immediately stop.
This PR fixes this issue.