chore(rln-relay): refactor mounting procedure #1457
Conversation
rymnc
added
the
track:rln
|
Checks are intermittently failing due to an unrelated error - |
Could you file this failure in #1357? |
Already exists :) (the last one) |
There was a problem hiding this comment.
LGTM ✅
A comment for future refactoring work:
If I understand the RLN module correctly, we have two mount protocol modes selected by the
rlnRelayDynamicconfiguration flag.To boost this module's extensibility and maintainability (e.g. testability), we should generalize the RLN protocol by extracting an interface that covers both modes and provides this behaviour through the constructor (check the driver interface and how we "inject" it into the Waku archive instance).
We can have a synchronous analysis and design session if needed 😁
Agreed, I'll do that as part of #1370, thanks for your review :) |
| # set up three nodes | ||
| # node1 |
There was a problem hiding this comment.
No, it isn't, if you're referring to different tests that setup 3 nodes, they test something different each time ;)
| return err("dynamic rln-relay could not be mounted: " & rlnRelayRes.error()) | ||
| let wakuRlnRelay = rlnRelayRes.get() | ||
| if persistCredentials: | ||
| # TODO should be replaced with key-store with proper encryption |
There was a problem hiding this comment.
Probably this comment can be removed now
There was a problem hiding this comment.
Indeed! addressed in e8f4aaa
Refactors the mounting procedure of waku-rln-relay