fix: change message ID provider to match go-waku #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
approved these changes
Feb 13, 2023
Menduist
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
messageIdProviderin nwaku usesMultihashformat, while in go-waku straightforwardsha256hashes are used. This implies that message IDs (e.g. in the seen cache, in control messages, etc.) do not match between go-waku and nwaku, resulting in a lot of duplication and unnecessary control messages.Since nwaku is more easily upgraded than go-waku, this quickfix changes nwaku message IDs to match those of go-waku.
A longer term solution is to specify a hashing scheme in an RFC.