-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enr): added enr builder waku capabilities extension #1599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! left a non blocking comment.
proc withWakuCapabilities*(builder: var EnrBuilder, caps: varargs[Capabilities]) = | ||
withWakuCapabilities(builder, CapabilitiesBitfield.init(caps)) | ||
|
||
proc withWakuCapabilities*(builder: var EnrBuilder, caps: openArray[Capabilities]) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an opinion. I generally prefer one function rather than multiple ones. less code to read, more simple and clearer. not sure I see the value of having all three.
Isn't this too low level? Cool thing about the builder is abstracting away all this
withWakuCapabilities(..., caps: CapabilitiesBitfield))
Both are very similar.
withWakuCapabilities(Relay, Store)
withWakuCapabilities(@[Relay, Store])
tldr: I would just leave withWakuCapabilities(@[Relay, Store])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different proc
signatures, cover different use cases.
At first sight, you can see it as too low level, for example. But IIRC, this is the exact API we need to create an ENR in the Waku discv5 module. A similar thing happens with the multiple capabilities methods: it is not the same to pass a seq[T]
than a varargs[T]
. You can convert easily a varargs
instance into a sequence, but the opposite has some compilation-time implications. The varargs
type can be understood as an array of known sizes at compile time, on the other hand, the sequence type is a dynamic size (pointer, length, and capacity backed) list of elements.
b95ed12
to
edd4c8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR introduces the Waku ENR capabilities field extension to the
EnrBuilder
type.EnrBuilder
Waku node capabilities extension.