Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump container image versions to v0.16.0 in quickstart #1640

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Mar 31, 2023

closes #1667

@LNSD
Copy link
Contributor

LNSD commented Apr 3, 2023

Hi @vpavlin, I think we should have a latest tag for the image, which should be updated when a new container image is released. With that, we can avoid updating the README.md with every new version.

cc @jm-clius

@vpavlin
Copy link
Member Author

vpavlin commented Apr 3, 2023

The latest tag is currently over a year old:) So if we can fix it to point to the latest release, we can absolutely use that.

We should mention in the quickstart that using latest in production is a bad practice since you would potentially lose control of when and how to update in case the latest image is retagged.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I agree that we could use latest here, though this is an example on how to use a specific release. I don't necessarily think we need to update it every time, though it's good that it's not way too old.

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

We can merge it as it is, and when we do the next release, we generate the latest tag and update this one last time :)

@vpavlin vpavlin force-pushed the docs/update-latest-image branch 3 times, most recently from 7ad319f to b34df5e Compare April 11, 2023 14:50
@vpavlin vpavlin force-pushed the docs/update-latest-image branch from b34df5e to d0504e6 Compare April 11, 2023 14:52
@vpavlin vpavlin merged commit 5c33d9d into waku-org:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Update quickstart with v0.16.0
3 participants