Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix test failing intermittently #1679

Merged
merged 1 commit into from
Apr 17, 2023
Merged

chore: fix test failing intermittently #1679

merged 1 commit into from
Apr 17, 2023

Conversation

alrevuelta
Copy link
Contributor

  • Fix test failing intermittently by increasing the delay.
  • Since multiple messages were being sent, we need to wait a bit more for the gossip. Without that, we are asserting before the test is really completed.
  • The issue is more prone to appear with debug or trace logs. New delay value leaves enough time.

@alrevuelta alrevuelta requested a review from LNSD April 17, 2023 11:38
LNSD
LNSD approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@alrevuelta alrevuelta merged commit 8d213e8 into master Apr 17, 2023
@alrevuelta alrevuelta deleted the flaky-test-1 branch April 17, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LNSD LNSD LNSD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alrevuelta @LNSD