chore: refactor flaky test with while

[alrevuelta]

Aims to fix couple of flaky tests by:

• Increasing the time we wait before the assert.
• Running a while loop with a max number of attempts. So instead of waiting a fixed amount of time, we set a maximum number of attempts before it fails. If the tests succeedes before, it shorten execution time.

[Ivansete-status]

That is great indeed.
I like the idea of having a more precise wait.
However, I would encapsulate it in a generic proc that waits for a certain condition to be true (20 attempts 0.5s each by default). If the max attempts is exceeded then fail the test in that point showing the condition didn't occur.

The important thing is to make sure the desired condition is met (require). If not, then notify it clearly.

[alrevuelta]

yup agree, the thing is that it might be tricky to have a generic proc, since in some cases it can be one condition, in others multiple ones (like here). each condition(s) can have a different value etc.

also i prefer an explicit check value1 == value2 instead of a proc just returning true/false and then asserting for that, since when asserting for value1==value2, you get the actual values, which gives more granularity for debugging.

but for sure, once we start doing this for other tests, i think we can come up with something more fancy than this.

[jm-clius]

LGTM as an improvement.

[vpavlin]

lgtm