Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): extend and rename nightly workflow to support RC builds #1784

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Jun 7, 2023

Description

This PR updates Nightly build workflow to also support building and create release candidate (RC) tags and releases.

It also adds version (e.g. nightly, v0.18.0-rc.0...) to artifact filenames.

I also removed the cache as it might make sense to "build from scratch" for releases, but I don't have a strong opinion on this

You can see the example pre-releases here: https://github.com/nwaku-test-org/nwaku/releases

I've also RC release steps to the release process docs

FYI We have a v0.18.0 release scheduled for next week, so I'd like to use this workflow on Friday to release the v0.18.0-rc.0

Changes

  • rename nightly to pre-release workflow
  • add support for *-rc.X releases to the workflo
  • add info about RC releases to release process doc

@vpavlin vpavlin force-pushed the chore/add-release-candidate-ci branch 6 times, most recently from f9de4f8 to cba8458 Compare June 7, 2023 15:51
@vpavlin vpavlin force-pushed the chore/add-release-candidate-ci branch from cba8458 to 78e5d9f Compare June 7, 2023 15:51
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving this process.

@vpavlin
Copy link
Member Author

vpavlin commented Jun 8, 2023

@rymnc the experimental test seems to be a bit flaky here:)

@rymnc
Copy link
Contributor

rymnc commented Jun 8, 2023

Let me check and get back to you @vpavlin

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thanks for it!
I think it is a good idea to generate RC from scratch.
On the other hand, I wouldn't do anything around wakunode1 (build & package) as we are going to deprecate it someday soon.

Comment on lines +64 to +65
make QUICK_AND_DIRTY_COMPILER=1 V=1 CI=false NIMFLAGS="-d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}}" \
wakunode1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are almost deprecating the wakunode1.
I wouldn't add it to the release package, just to avoid confusion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is currently part of it (https://github.com/waku-org/nwaku/blob/master/.github/workflows/release-assets.yml#L57), so I wanted to make sure we keep things relatively unchanged until the repo refactoring is done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, thanks for letting me know!

@vpavlin
Copy link
Member Author

vpavlin commented Jun 8, 2023

@rymnc seems like the test passed this time (3rd run) - would be probably good to check if there is a possibility of some kind of race condition (or what other "flaky" CI behaviour could cause this - e.g. if resource limited environment can influence the outcome of the test

@vpavlin vpavlin merged commit 9607407 into master Jun 8, 2023
@vpavlin vpavlin deleted the chore/add-release-candidate-ci branch June 8, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants