-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): extend and rename nightly workflow to support RC builds #1784
Conversation
f9de4f8
to
cba8458
Compare
cba8458
to
78e5d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for improving this process.
@rymnc the experimental test seems to be a bit flaky here:) |
Let me check and get back to you @vpavlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thanks for it!
I think it is a good idea to generate RC from scratch.
On the other hand, I wouldn't do anything around wakunode1
(build & package) as we are going to deprecate it someday soon.
make QUICK_AND_DIRTY_COMPILER=1 V=1 CI=false NIMFLAGS="-d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}}" \ | ||
wakunode1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are almost deprecating the wakunode1.
I wouldn't add it to the release package, just to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is currently part of it (https://github.com/waku-org/nwaku/blob/master/.github/workflows/release-assets.yml#L57), so I wanted to make sure we keep things relatively unchanged until the repo refactoring is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool, thanks for letting me know!
@rymnc seems like the test passed this time (3rd run) - would be probably good to check if there is a possibility of some kind of race condition (or what other "flaky" CI behaviour could cause this - e.g. if resource limited environment can influence the outcome of the test |
Description
This PR updates Nightly build workflow to also support building and create release candidate (RC) tags and releases.
It also adds
version
(e.g.nightly
,v0.18.0-rc.0
...) to artifact filenames.I also removed the cache as it might make sense to "build from scratch" for releases, but I don't have a strong opinion on this
You can see the example pre-releases here: https://github.com/nwaku-test-org/nwaku/releases
I've also RC release steps to the release process docs
FYI We have a
v0.18.0
release scheduled for next week, so I'd like to use this workflow on Friday to release thev0.18.0-rc.0
Changes
*-rc.X
releases to the workflo