Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Topic verification & ENR update #1792

Closed
wants to merge 2 commits into from
Closed

feat: Topic verification & ENR update #1792

wants to merge 2 commits into from

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jun 12, 2023

Description

A step towards setting up nodes for sharded topics.

Changes

  • Parse topics from config then check their validity according to https://rfc.vac.dev/spec/51/
  • Update ENR with sharded topic info if needed.

step 1 of #1776

Feedback

Looking for all kind of feedback but more specifically on;

  • Had to make some func public. Could be undone in next step when discovery is re-org. Not sure yet. Otherwise maybe we want to change the ergonomics around RelayShard <-> Record.
  • Not using the already parsed topics seams inelegant. What do?
  • Could leave the new code where it is and re-org once discovery is changed. Otherwise, where does this new code fit IDK?

@SionoiS SionoiS changed the title Topic verification & ENR update feat: Topic verification & ENR update Jun 12, 2023
@SionoiS SionoiS closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SionoiS