Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): bump zerokit #1870

Closed
wants to merge 1 commit into from
Closed

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 2, 2023

Description

Bumps zerokit to latest head https://github.com/vacp2p/zerokit/tree/ecb4d9307f42d033c00303ff4921d1432dff628d to include a fix to the atomic_operation api reported by @richard-ramos

Changes

  • Bumps zerokit submodule

@rymnc rymnc added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Aug 2, 2023
@rymnc rymnc self-assigned this Aug 2, 2023
@rymnc rymnc requested review from SionoiS and vpavlin August 2, 2023 05:15
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, so I have to assume it is ok:D

What would be a way for reviewers to review this "properly"?

I guess the per-PR simulations could help here?

@rymnc
Copy link
Contributor Author

rymnc commented Aug 2, 2023

CI passes, so I have to assume it is ok:D

What would be a way for reviewers to review this "properly"?

I guess the per-PR simulations could help here?

Yes, I believe simulations would go a long way to test submodule updates

@rymnc
Copy link
Contributor Author

rymnc commented Aug 7, 2023

Closing this PR in favor of #1886

@rymnc rymnc closed this Aug 7, 2023
@rymnc rymnc deleted the bump-zerokit-02-08-2023 branch August 7, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants