-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add docker image builds per PR #1881
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Dockerfile to build a distributable container image from pre-existing binaries | ||
FROM debian:stable-slim as prod | ||
|
||
ARG MAKE_TARGET=wakunode2 | ||
|
||
LABEL maintainer="vaclav@status.im" | ||
LABEL source="https://github.com/waku-org/nwaku" | ||
LABEL description="Wakunode: Waku client" | ||
LABEL commit="unknown" | ||
|
||
# DevP2P, LibP2P, and JSON RPC ports | ||
EXPOSE 30303 60000 8545 | ||
|
||
# Referenced in the binary | ||
RUN apt-get update &&\ | ||
apt-get install -y libpcre3 libpq-dev &&\ | ||
apt-get clean && rm -rf /var/lib/apt/lists/* | ||
|
||
# Fix for 'Error loading shared library libpcre.so.3: No such file or directory' | ||
RUN ln -s /usr/lib/libpcre.so /usr/lib/libpcre.so.3 | ||
|
||
# Copy to separate location to accomodate different MAKE_TARGET values | ||
ADD ./build/$MAKE_TARGET /usr/local/bin/ | ||
|
||
# Copy migration scripts for DB upgrades | ||
ADD ./migrations/ /app/migrations/ | ||
|
||
# Symlink the correct wakunode binary | ||
RUN ln -sv /usr/local/bin/$MAKE_TARGET /usr/bin/wakunode | ||
|
||
ENTRYPOINT ["/usr/bin/wakunode"] | ||
|
||
# By default just show help if called without arguments | ||
CMD ["--help"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a comment at the top indicating the expected purpose of this Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add a comment there - something like "A Dockerfile to build a distributable container image from pre-existing binaries" ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that sounds great!