fix: bring back default topic in config #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at |
Ivansete-status
requested changes
Aug 11, 2023
There was a problem hiding this comment.
Morning and thanks for this!
However, I have the impression that we are missing changes in the app.nim file to also support the topic param:
Line 363 in b9d5d28
|
You can find the image built from this PR at |
|
You can find the image built from this PR at |
|
Now it should work with |
|
You can find the image built from this PR at |
vpavlin
approved these changes
Aug 11, 2023
rymnc
pushed a commit
that referenced
this pull request
Aug 16, 2023
* fix: bring back default topic in config * fix * Fix a bug * Fix enr creation
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If #1857 is not merged in time for v0.19
Fix #1896