Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln): run rln in all relay pubsubtopics + remove cli flags #1917

Merged
merged 1 commit into from
Aug 21, 2023
Merged

chore(rln): run rln in all relay pubsubtopics + remove cli flags #1917

merged 1 commit into from
Aug 21, 2023

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Aug 18, 2023 •
edited
Loading

Changes

  • Remove rln-relay-pubsub-topic and rln-relay-content-topic cli flags.
  • Remove all references to pubsub and content topics in rln.
  • Mount rln in all pubsub topics that relay is configured with.
  • Adds tests to ensure that rln is applied in all pubsub/content topics configured in relay.

Related #1906

@alrevuelta alrevuelta mentioned this pull request Aug 18, 2023
Closed
56 tasks
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1917

jm-clius
jm-clius approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

rymnc
rymnc reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, small query

waku/waku_rln_relay/rln_relay.nim Show resolved Hide resolved
rymnc
rymnc approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alrevuelta alrevuelta merged commit af95b57 into master Aug 21, 2023
@alrevuelta alrevuelta deleted the apply-rln-all-ctops branch August 21, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@rymnc rymnc rymnc approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrevuelta @rymnc @jm-clius