feat(rln_keystore_generator): wired to onchain group manager #1931
Conversation
|
You can find the image built from this PR at |
rymnc
force-pushed
the
rln-credential-tool-3
branch
from
9b97ffe
to
302e6fb
Compare
rymnc
force-pushed
the
rln-credential-tool-3
branch
from
302e6fb
to
7235bc3
Compare
Makefile
Outdated
| @@ -186,7 +186,7 @@ chat2: | build deps librln | |||
|
|
|||
| rln_keystore_generator: | build deps librln | |||
There was a problem hiding this comment.
I'd go for rln-keystore-generator. General Makefile convention is that words in target names are not separated at all or separated by a hyphen. See https://style-guides.readthedocs.io/en/latest/makefile.html#targets
|
|
||
| # 5. register on-chain | ||
| try: | ||
| waitFor groupManager.register(credential) |
There was a problem hiding this comment.
Solving this is not related to this PR but if we have a tool to register a membership in nwaku perhaps we should fix this status-im/nim-web3#79 ? May take some time though.
I don't think you are able to broadcast a tx without a chaindId so this groupManager.register will most likely fail unless your Ethereum node uses rpc.allow-unprotected-txs, and afaik thats disabled in most of the cases. So someone using this tool will most likely run into this.
There was a problem hiding this comment.
very nice catch! will try to make some time to fix that!
Description
Hooks up the rln_keystore_generator to the OnchainGroupManager.
Changes