fix(Makefile): error out if rln-keystore-generator not compiled with rln flag #1960
Conversation
Makefile
Outdated
| ifeq ($(RLN),true) | ||
| echo -e $(BUILD_MSG) "build/$@" && \ | ||
| $(ENV_SCRIPT) nim rln_keystore_generator $(NIM_PARAMS) $(EXPERIMENTAL_PARAMS) waku.nims | ||
| else | ||
| $(error RLN is not true. To build rln-keystore-generator, set RLN=true.) | ||
| endif |
There was a problem hiding this comment.
not sure if there's a better way to make RLN default to true while building this target - thoughts @vpavlin?
There was a problem hiding this comment.
Hey @rymnc !
Maybe we could do sth like the next:
https://gist.github.com/Ivansete-status/fbd0c075658f942b2f9a5c111ae4ef1b#file-makefile-L138
https://gist.github.com/Ivansete-status/fbd0c075658f942b2f9a5c111ae4ef1b#file-makefile-L145
https://gist.github.com/Ivansete-status/fbd0c075658f942b2f9a5c111ae4ef1b#file-makefile-L190
There was a problem hiding this comment.
oh! good idea, i'll add that
thanks!
|
You can find the image built from this PR at |
yeah, not sure how to |
|
seems that by default its compiled with TRACE, so perhaps we should add this to the instructions. |
Yeah im working on the readme for it |
|
btw, it works fine but I see |
because when the tree has just been created, the metadata does not exist when we try to fetch it. |
Description
This pr is associated to #1956 (comment)
We need to ensure that RLN is set to true when compiling the
rln-keystore-generatortargetChanges