Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use commit instead of master for docker image #1990

Merged
merged 1 commit into from
Sep 5, 2023
Merged

chore(ci): use commit instead of master for docker image #1990

merged 1 commit into from
Sep 5, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Sep 4, 2023 •
edited
Loading

Description

per @alrevuelta's reuest - replacing master tag with git commit for traceability

Changes

  • replace master tag with git rev-parse --short HEAD output

@vpavlin vpavlin force-pushed the chore/add-commit-tag branch from f55cac3 to b6e080b Compare September 4, 2023 13:42
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1990

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:1990-experimental

alrevuelta
alrevuelta approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! unsure if ci failure is related.

@vpavlin
Copy link
Member Author

vpavlin commented Sep 4, 2023

thanks! unsure if ci failure is related.

No, I don't think it is

Ivansete-status
Ivansete-status approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That awesome! Thanks for it !

@vpavlin vpavlin merged commit 9885019 into master Sep 5, 2023
14 checks passed
@vpavlin vpavlin deleted the chore/add-commit-tag branch September 5, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpavlin @alrevuelta @Ivansete-status