Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): List possible WSL Issue #1995

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Sep 6, 2023

Description

Update README with some relevant information/issues I found while setting up the nwaku environment in my computer, namely:

  • A possible fix to building issues when working on WSL.
  • Bundled nim runtime

@AlejandroCabeza AlejandroCabeza changed the title Add disclaimer on WSL building issue to README. docs(README): List WSL Issue Sep 6, 2023
@AlejandroCabeza AlejandroCabeza changed the title docs(README): List WSL Issue docs(README): List possible WSL Issue Sep 6, 2023
@AlejandroCabeza AlejandroCabeza self-assigned this Sep 6, 2023
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it!

Comment on lines +38 to +40
#### Issues
##### WSL
If you encounter difficulties building the project on WSL, consider placing the project within WSL's filesystem, avoiding the `/mnt/` directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine to have this for now. If the list keeps growing we might think of having this in a separate place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree :)

@AlejandroCabeza AlejandroCabeza merged commit ebe715e into master Sep 11, 2023
12 checks passed
@AlejandroCabeza AlejandroCabeza deleted the wsl-building-disclaimer branch September 11, 2023 16:06
@AlejandroCabeza AlejandroCabeza restored the wsl-building-disclaimer branch September 11, 2023 16:06
@AlejandroCabeza AlejandroCabeza deleted the wsl-building-disclaimer branch September 11, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants