feat(rln-relay): removed rln from experimental 🚀

[rymnc]

Description

This PR removes rln from the experimental feature set, as the acceptance criteria for #1906

Changes

• updated makefile targets to make rln compiled by default
• removed all references to when defined(rln)
• updated github action workflow manifests

note: i left in the EXPERIMENTAL flag for any future protocol that will be experimental, it seems to
make sense to leave it in instead of removing it and then adding it back in when its needed, but open to
opinions

Removed the EXPERIMENTAL flag, and all its usages

How to test

1. Build wakunode2 as usual, rln will be included make -j12 wakunode2
2. Run tests as usual, rln tests will run too make -j12 test

Issue

closes #1906

[rymnc]

had to be deleted - actions was acting out
@vpavlin is there a way to leave the file in but disable the workflow?

[vpavlin]

Yes, we can manually disable workflows through GH actions UI

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2001

Built from a4839d1

[alrevuelta]

lgtm! left a comment.

[alrevuelta]

mm with this a node that doesnt have rln enabled will never be ready. perhaps we should add the return true back?
but yeah, problem is, if wakuRlnRelay=nil is it because i) rln is not enabled and we are ready or because ii) rln is enabled but not mounted and in this case we are not ready.

[rymnc]

wakuRlnRelay is nil whenever the --rln-relay flag is not passed in

[rymnc]

Addressed in 88bfe6e

[vpavlin]

LGTM apart from the @alrevuelta's comment on isReady:) But I don't see any "right and quick" solution

[rymnc]

@NagyZoltanPeter would you maybe know why the ci failed on this test?

2023-09-08T13:28:03.3911193Z �[96mINF�[0m 2023-09-08 13:28:03.389+00:00 �[1mstopping rln-relay                        �[0m topics="�[93mwaku rln_relay�[0m" �[96mtid�[0m=�[94m10538�[0m �[96mfile�[0m=�[94mrln_relay.nim:88�[0m

[NagyZoltanPeter]

@NagyZoltanPeter would you maybe know why the ci failed on this test?

2023-09-08T13:28:03.3911193Z �[96mINF�[0m 2023-09-08 13:28:03.389+00:00 �[1mstopping rln-relay                        �[0m topics="�[93mwaku rln_relay�[0m" �[96mtid�[0m=�[94m10538�[0m �[96mfile�[0m=�[94mrln_relay.nim:88�[0m

Ah .... Actually I should have foresee this.
I was testing fake m false case with not having waku rln not mounted.
So it leads to that we need a more sophisticated isReady as we discussed already. Due we need to check against config what happened and what state we are.

For now I would suggest remove failure case from test_rest_health to quick fix it for now.

I will add a new issue to track this further.