Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cbindings): avoid using global var in libwaku.nim #2118

Merged
merged 7 commits into from
Oct 23, 2023

Commits on Oct 6, 2023

  1. Configuration menu
    Copy the full SHA
    671500b View commit details
    Browse the repository at this point in the history
  2. libwaku: Avoid global variable and changing callback signature

    * Avoid using a global variable to store the Context object.
    
    * Better signature for the callback. Two new parameters added:
      one aimed to allow passing the caller result code; and the other
      param is to pass an optional userData pointer that might need
      to be linked locally with the Context object. This is needed
      in Rust for example, to make the passed closures to live as
      long as the Context.
    Ivansete-status committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    02a003f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68555ea View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    0614b89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    002c61f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    d04d908 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    396677b View commit details
    Browse the repository at this point in the history