Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): update changelog for v0.21.0 release #2128

Merged
merged 7 commits into from
Oct 18, 2023
Merged

chore(release): update changelog for v0.21.0 release #2128

merged 7 commits into from
Oct 18, 2023

Conversation

gabrielmer
Copy link
Contributor

Description

Changelog for v0.21.0

Please review carefully and suggest highlights, upgrade instructions or notes that should be added :)

Changes

  • updated changelog

@gabrielmer gabrielmer self-assigned this Oct 13, 2023
@gabrielmer gabrielmer requested a review from vpavlin October 13, 2023 15:22
@gabrielmer gabrielmer changed the title Chore/changelog v0.21.0 chore(release): update changelog for v0.21.0 release Oct 13, 2023
@gabrielmer gabrielmer marked this pull request as ready for review October 13, 2023 15:49
@s-tikhomirov
Copy link
Contributor

LGTM (modulo a few typos).

NagyZoltanPeter
NagyZoltanPeter reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on items I can remember and judge. Thank you.

@gabrielmer
Copy link
Contributor Author

LGTM (modulo a few typos).

Thank you! Please let me know about any typo that you find to fix it :)

Notice that a great part of the text is PR titles. Not sure if we should change those in case they have typos

rymnc
rymnc approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alrevuelta
alrevuelta reviewed Oct 16, 2023
View reviewed changes
Ivansete-status
Ivansete-status reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
Just added a little comment about the size-based retention policy.

CHANGELOG.md Outdated
* Implemented a req/resp [protocol](https://rfc.vac.dev/spec/66/) that provides information about the node's medatadata
* Added REST APIs for Filter v2 and Lightpush protocols' services
* Ported /admin endpoint to REST
* Added a size-based retention policy for the user to set a limit for storage used
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is important to indicate that the size-based retention policy was tested when SQLite was set as a storage system. We will need to revisit this feature to make sure it works well on Postgres too.

CC: @ABresting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I changed that line specifying that it is for SQLite storage and added a note at the end mentioning that the size-based retention policy was tested with SQLite and is still being validated with Postgres

vpavlin
vpavlin approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

@s-tikhomirov
Copy link
Contributor

Please let me know about any typo that you find to fix it :)

I left a couple of comments, but I agree, these are all minor.

@gabrielmer
Copy link
Contributor Author

I left a couple of comments, but I agree, these are all minor.

I'm not finding the comments you mention, maybe they didn't get submitted?

@gabrielmer gabrielmer requested a review from alrevuelta October 18, 2023 06:58
s-tikhomirov
s-tikhomirov approved these changes Oct 18, 2023
View reviewed changes
@gabrielmer gabrielmer force-pushed the chore/changelog-v0.21.0 branch from 08dce30 to 61c1ca5 Compare October 18, 2023 12:45
NagyZoltanPeter
NagyZoltanPeter approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Thank you

@gabrielmer gabrielmer merged commit 86af8fb into master Oct 18, 2023
@gabrielmer gabrielmer deleted the chore/changelog-v0.21.0 branch October 18, 2023 14:39
omahs pushed a commit to omahs/nwaku that referenced this pull request Nov 21, 2023
@gabrielmer @omahs
chore(release): update changelog for v0.21.0 release (waku-org#2128)
e962ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpavlin vpavlin vpavlin approved these changes

@s-tikhomirov s-tikhomirov s-tikhomirov approved these changes

@rymnc rymnc rymnc approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@SionoiS SionoiS Awaiting requested review from SionoiS

@jm-clius jm-clius Awaiting requested review from jm-clius

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gabrielmer @s-tikhomirov @vpavlin @alrevuelta @rymnc @NagyZoltanPeter @Ivansete-status @SionoiS @jm-clius