chore: improving node setup w.r.t sharding information #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
changed the title
SionoiS
added
the
E:1.4: Sharded peer management and discovery
|
You can find the image built from this PR at Built from 626b852 |
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
3 times, most recently
from
e3c6974 to
b0aaa70
Compare
gabrielmer
reviewed
Nov 10, 2023
alrevuelta
reviewed
Nov 10, 2023
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
from
e1162a7 to
13d21a9
Compare
SionoiS
requested review from
jm-clius
and removed request for
Ivansete-status
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
2 times, most recently
from
de8062e to
74aa3f8
Compare
jm-clius
approved these changes
Nov 15, 2023
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
3 times, most recently
from
ff4c433 to
8d7b521
Compare
|
I don't get it! All test green locally but it always fail here...... |
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
2 times, most recently
from
dc5efd2 to
416757d
Compare
SionoiS
force-pushed
the
chore--refactor-shard-flow
branch
from
416757d to
11cabad
Compare
|
Seams like the bug is fixed. Merging even with JS failing as it's not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various misc. fixes and changes related to shards, Waku metadata and testings.
Motivated by #2151 which made me realized testing was not ergonomic w.r.t. sharding.
Changes
Close #2183