Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove trailing commas from keystore json #2200

Merged
merged 9 commits into from
Dec 1, 2023
Merged

fix: remove trailing commas from keystore json #2200

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d24c62
fix: remove trailing commas from keystore json
weboko Nov 8, 2023
36cdda5
Merge branch 'master' into weboko/keystore-json
weboko Nov 20, 2023
9334c74
Merge branch 'master' into weboko/keystore-json
weboko Nov 21, 2023
f83fcb9
Merge branch 'master' into weboko/keystore-json
weboko Nov 27, 2023
658a125
Merge branch 'master' of github.com:waku-org/nwaku into weboko/keysto…
weboko Nov 28, 2023
a8c5c6f
keyfile.nim: try a different Json formatting approach
Ivansete-status Nov 30, 2023
8ecc8a7
Merge branch 'weboko/keystore-json' of github.com:waku-org/nwaku into…
weboko Nov 30, 2023
140a1b8
build keystore
weboko Nov 30, 2023
87c6c22
address comment
weboko Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions waku/waku_keystore/keyfile.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,24 +373,22 @@ proc createKeyFileJson*(secret: openArray[byte],

let params = ? kdfParams(kdfkind, toHex(salt, true), workfactor)

let json = %*
{
"crypto": {
"cipher": $cryptkind,
"cipherparams": {
"iv": toHex(iv, true)
},
"ciphertext": toHex(ciphertext, true),
"kdf": $kdfkind,
"kdfparams": params,
"mac": toHex(mac.data, true),
},
}

if IdInKeyfile:
json.add("id", %($u))
if VersionInKeyfile:
json.add("version", %version)
let json = %* (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno if it the best way to address it 🤷‍♂️

"{" &
" crypto: {" &
" cipher: " & $cryptkind & "," &
" cipherparams: {" &
" iv: " & toHex(iv, true) &
" }," &
" ciphertext: " & toHex(ciphertext, true) & "," &
" kdf: " & $kdfkind & "," &
" kdfparams: " & $params & "," &
" mac: " & toHex(mac.data, true) &
" }" &
(if IdInKeyfile: ", id: " & $u else: "") &
(if VersionInKeyfile: ", version: " & $version else: "") &
"}"
)

ok(json)

Expand Down
Loading