chore(rest): improved message cache logic

[SionoiS]

Description

I refactored the message cache with the intent to allow fetching messages by pubsub OR content topic. Adding a message now add the missing topic either pubsub or content (still need to be subscribed to either). I also added a check to prevent duplicate messages.

The capacity is now TOTAL instead of PER topic.

Changes

• new message cache
• updated APIs
• new tests for new behaviour

Tracking: #2201
Fix: #2192

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2221

Built from d3d4bf1

[jm-clius]

Generally LGTM. Since the cache here is generally very small, I would have imagined that a simple, less efficient structure (e.g. just iterating through the cache to get and remove messages based on a filter) would be acceptable, but there may be some complexity that I'm missing.

[SionoiS]

Generally LGTM. Since the cache here is generally very small, I would have imagined that a simple, less efficient structure (e.g. just iterating through the cache to get and remove messages based on a filter) would be acceptable, but there may be some complexity that I'm missing.

I discussed the impl. at length with @gabrielmer and yes, not my best work. It's done, it works, I don't want to spend even more time on this.

[jm-clius]

I don't want to spend even more time on this

Fair enough 😄

[gabrielmer]

LGTM! Thanks so much! 🤩