Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store-archive): Remove duplicated code #2234

Merged
merged 2 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tests/common/test_sqlite_migrations.nim
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,18 @@ import
stew/results,
testutils/unittests
import
../../waku/common/databases/db_sqlite {.all.}
../../waku/common/databases/db_sqlite {.all.},
../waku_archive/archive_utils


proc newTestDatabase(): SqliteDatabase =
SqliteDatabase.new(":memory:").tryGet()

template sourceDir: string = currentSourcePath.rsplit(DirSep, 1)[0]


suite "SQLite - migrations":

test "set and get user version":
## Given
let database = newTestDatabase()
let database = newSqliteDatabase()

## When
let setRes = database.setUserVersion(5)
Expand Down
2 changes: 0 additions & 2 deletions tests/node/test_wakunode_filter.nim
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import
testutils
]

let FUTURE_TIMEOUT = 1.seconds

suite "Waku Filter - End to End":
var client {.threadvar.}: WakuNode
var clientPeerId {.threadvar.}: PeerId
Expand Down
56 changes: 56 additions & 0 deletions tests/waku_archive/archive_utils.nim
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{.used.}

import
std/options,
chronos,
chronicles,
libp2p/crypto/crypto

import
../../../waku/[
node/peer_manager,
waku_core,
waku_archive,
waku_archive/common,
waku_archive/driver/sqlite_driver,
common/databases/db_sqlite,
waku_store
],
../testlib/[
common,
wakucore
]


proc newSqliteDatabase*(): SqliteDatabase =
SqliteDatabase.new(":memory:").tryGet()


proc newSqliteArchiveDriver*(): ArchiveDriver =
let database = newSqliteDatabase()
SqliteDriver.new(database).tryGet()


proc newWakuArchive*(driver: ArchiveDriver): WakuArchive =
WakuArchive.new(driver).get()


proc computeArchiveCursor*(pubsubTopic: PubsubTopic, message: WakuMessage): ArchiveCursor =
ArchiveCursor(
pubsubTopic: pubsubTopic,
senderTime: message.timestamp,
storeTime: message.timestamp,
digest: waku_archive.computeDigest(message)
)


proc newArchiveDriverWithMessages*(pubsubTopic: PubSubTopic, msgList: seq[WakuMessage]): ArchiveDriver =
let driver = newSqliteArchiveDriver()

for msg in msgList:
let
msgDigest = waku_archive.computeDigest(msg)
msgHash = computeMessageHash(pubsubTopic, msg)
discard waitFor driver.put(pubsubTopic, msg, msgDigest, msgHash, msg.timestamp)

return driver
13 changes: 3 additions & 10 deletions tests/waku_archive/test_driver_sqlite.nim
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,16 @@ import
../../../waku/waku_archive,
../../../waku/waku_archive/driver/sqlite_driver,
../../../waku/waku_core,
../waku_archive/archive_utils,
../testlib/common,
../testlib/wakucore


proc newTestDatabase(): SqliteDatabase =
SqliteDatabase.new(":memory:").tryGet()

proc newTestSqliteDriver(): ArchiveDriver =
let db = newTestDatabase()
SqliteDriver.new(db).tryGet()


suite "SQLite driver":

test "init driver and database":
## Given
let database = newTestDatabase()
let database = newSqliteDatabase()

## When
let driverRes = SqliteDriver.new(database)
Expand All @@ -45,7 +38,7 @@ suite "SQLite driver":
## Given
const contentTopic = "test-content-topic"

let driver = newTestSqliteDriver()
let driver = newSqliteArchiveDriver()

let msg = fakeWakuMessage(contentTopic=contentTopic)

Expand Down
Loading