fix(rln-relay): graceful retries on rpc calls #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
E:RLN on mainnet
|
You can find the image built from this PR at Built from 90074c2 |
|
for the js-waku integration test seems that some peer management test is failing, should be OK on our side |
Ivansete-status
approved these changes
Nov 30, 2023
Comment on lines
+147
to
+148
| retryWrapper(gasPrice, RetryStrategy.new(), "Failed to get gas price"): | ||
| int(await ethRpc.provider.eth_gasPrice()) * 2 |
There was a problem hiding this comment.
Nitpick. Shall we have a little comment explaining why * 2?
| except CatchableError: | ||
| error "failed to get the current block number", error = getCurrentExceptionMsg() | ||
| return false | ||
| retryWrapper(currentBlock, RetryStrategy.new(), "Failed to get the current block number"): |
There was a problem hiding this comment.
Nitpick. I see the RetryStrategy.new() is always being used. I wonder if we could clean it a little and have it created as a default parameter value.
That applies elsewhere.
Suggested change
| retryWrapper(currentBlock, RetryStrategy.new(), "Failed to get the current block number"): | |
| retryWrapper(currentBlock, "Failed to get the current block number"): |
There was a problem hiding this comment.
I tried having it set as default in the template, but templates don't allow that with multiple params afaik
|
cc: @alrevuelta for a review please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces graceful retries for rpc calls made by the onchain group manager to improve robustness of rln-relay.
Changes
retry_wrapperthat exposes a templateretryWrapperthat accepts a retry strategy, error string and res varTODO:
Issue
closes #2217
closes #2204