-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: making filter admin data test order independent #2355
Conversation
You can find the image built from this PR at
Built from 06d3741 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with only small remarks.
We may think of how to compare resultset unordered.
Also now this change is in contradict with my PR.. but that can be solved as soon as this one gets merged.
Yes! I changed the case to check for the number of content topics subscribed and not their values to avoid complexity, as I think the check is strong enough in this case. The problem here why I didn't use a set is that there's two layers of order: there's the list of peers, and within each peer there's a list of content topics. So we would have to use a set of sets, or something like that, and might overcomplicate things. There might be a more elegant solution, we can think it through :). Sorting is also a option but kind of tedious in this case, for the same reason.
Yes! Once this is merged we'll probably have to rebase your PR to include this fix :)) |
82e75fd
to
11a5ce4
Compare
Description
Generalized test to not rely on order of neither peers subscriptions nor of subscription criteria within each peer.