chore(rln-relay): remove websocket from OnchainGroupManager

[rymnc]

Description

Removes dependence on eth_subscribe since websocket connections can be flaky.

Changes

• Removes eth_subscribe call and replaces it with block polling every 1 second. default can be changed

How to test

1. Pass in a http rpc provider instead of ws while running nwaku / make -j16 test
2. Generate an rln keystore using

./build/wakunode2 generateRlnKeystore \
  --rln-relay-cred-path:./rlnKeystore.json \
  --rln-relay-eth-client-address:https:<> \
  --rln-relay-cred-password:sup3rsecure \
  --rln-relay-eth-contract-address:0xF471d71E9b1455bBF4b85d475afb9BB0954A29c4 \
  --rln-relay-eth-private-key:<> \
  --execute

insert your https rpc provider as well as private key in the required positions

Issue

addresses part of #2345

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2364

Built from d9e245b

[gabrielmer]

I think that this proc either returns true or raises an exception.

Am I missing something or is it supposed to be like that? If so, what's the point of returning bool if the return value is always true?

[rymnc]

that's for compatibility with the retryWrapper template, it expects a return value to assign the result of an async operation, just set to true here since we don't use it (discarded)

[github-actions]

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

[gabrielmer]

LGTM! Thanks so much! 🤩

[alrevuelta]

lgtm thanks! minor comment regarding DefaultBlockPollRate

[alrevuelta]

Perhaps this is too often? Would suggest 6s (half-block time). Thinking here of people that may be using freemium providers. Once per second is 86.400 requests a day (and that just for knowing the current block).

On the other hand, since we consider as valid multiple roots, we could relax this further (thinking of >30sec). But lets leave this by now, as it may open up some edge cases. 6s should be ok by now.

[rymnc]

addressed in dbd6cc3