chore(rln-relay-v2): use rln-v2 contract code #2381
Conversation
rymnc
added
the
E:RLN on mainnet
|
You can find the image built from this PR at Built from 4ec1d8f |
| debug "Initial account balance: ", balance | ||
|
|
||
| # deploy registry contract with its constructor inputs | ||
| let receipt = await web3.deployContract(RegistryContractCode) |
There was a problem hiding this comment.
This is the only difference between the two branches of the when defined(rln_v2). Thereafter, I think is better to perform the when validation in a narrower scope instead of duplicating so much code.
There was a problem hiding this comment.
will make that change 👍
wanted to make it easier to transition from v1 to v2 by deleting whole functions
| let contractAddress = receipt.contractAddress.get() | ||
| debug "Address of the deployed registry contract: ", contractAddress | ||
| # deploy registry contract with its constructor inputs | ||
| let receipt = await web3.deployContract(RegistryContractCode, |
There was a problem hiding this comment.
Following my previous comment, this is the only diff (and its parameters.) Let's reduce the when scope if possible :)
| @@ -134,6 +138,10 @@ $(LIBRLN_FILE): | |||
|
|
|||
| librln: | $(LIBRLN_FILE) | |||
| $(eval NIM_PARAMS += --passL:$(LIBRLN_FILE) --passL:-lm) | |||
| ifeq ($(RLN_V2),true) | |||
There was a problem hiding this comment.
I have the impression that we won't test this in our CI. Shall we switch it manually in the future? To elaborate a bit more, I think we'd need to adapt the following somehow in the future:
nwaku/.github/workflows/ci.yml
Line 121 in bb58a63
There was a problem hiding this comment.
yes, at the moment rln-v2 is unstable in nwaku. when it's at a better state I'll add the flag similar to how we had it for experimental builds
Description
This PR adds rln-v2 contract code into the waku_rln_relay/contract.nim file
This PR also feature flags it with
rln_v2and updates the Makefile entry for conditional compilation as well.Changes
rln_v2rln_v2in tests and contract.nimIssue
closes #2375