Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add coverage target to Makefile #2382

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

romanzac
Copy link
Contributor

Description

Add coverage target to make coverage reporting more straightforward.

Changes

  • Makefile with coverage target in Docs section.
  • Add -y option to run_cov.sh silently when an old report exists.

Copy link

github-actions bot commented Jan 29, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2382

Built from b8e2155

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

@romanzac romanzac merged commit 5737887 into master Jan 30, 2024
8 of 10 checks passed
@romanzac romanzac deleted the chore-add-coverage-target branch January 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants