Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): regex pattern match for extended domains #2444

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Feb 16, 2024

Description

Fixed the regex pattern since the fleet url's are parsed as invalid. (tested with fleet url)

Changes

  • regex patterns

Copy link

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

@rymnc rymnc self-assigned this Feb 16, 2024
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rymnc rymnc requested review from SionoiS and removed request for alrevuelta February 16, 2024 16:08
Copy link

github-actions bot commented Feb 16, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2444

Built from 2512945

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@rymnc rymnc merged commit 29b0c0b into master Feb 16, 2024
10 checks passed
@rymnc rymnc deleted the fix-wss-regex branch February 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants