feat: negentropy c integ #2448
Merged
feat: negentropy c integ #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
reviewed
Feb 19, 2024
SionoiS
reviewed
Feb 21, 2024
waku/waku_sync/raw_bindings.nim
Outdated
|
|
||
| proc new*(T: type Negentropy, storage: Storage, frameSizeLimit: uint64): T = | ||
| let negentropy = constructNegentropy(storage, culong(frameSizeLimit)) | ||
| proc new_negentropy*(storage: pointer, frameSizeLimit: uint64): pointer = |
There was a problem hiding this comment.
I thinking we'll need objects wrapping storage and negentropy. pointers are not super ergonomic.
rymnc
reviewed
Mar 6, 2024
Ivansete-status
approved these changes
Mar 6, 2024
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
SionoiS
added a commit
that referenced
this pull request
Mar 7, 2024
# This is the 1st commit message: feat: Waku Sync Protocol periodic sync & peer manager Fixes ingess messages Bindings first draft Wrapping String to/from bytes Vector added missing binds & wraps added header files feat: negentropy c integ (#2448) * chore: move negentropy to a submodule * chore: add negentropy folder in vendor dir * moved submodule to c-wrapper branch * chore: updated negentropy * chore: udpate submodule URL to use https * chore: started integrating negetropy C wrapper * chore: fixed all compilation errors wrt C-wrapper integration * chore: include sync peers to be returned as part of REST API * chore: tested insert into storage and changes done for it. * chore: experimenting with callback * chore: first test for sync * chore: revert callback changes * chore: revert temp changes * chore: write tests to verify c integration * draft: in progress changes to integrate callback based method from C * chore: in progress callback integration * chore: first working sync example with c bindings * feat: added few tests for sync protocol * chore: copy negentropy so for build to work * chore: add negentropy as dependency for test targets * chore: try to fix CI compilation issue of negentropy * chore: apply suggestions from code review Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> * chore: fix naming convention changes --------- Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> # This is the commit message #2: update ref # This is the commit message #3: update submodule # This is the commit message #4: chore: consider leak fix in negentropy
SionoiS
added a commit
that referenced
this pull request
Mar 7, 2024
periodic sync & peer manager Fixes ingess messages Bindings first draft Wrapping String to/from bytes Vector added missing binds & wraps added header files feat: negentropy c integ (#2448) * chore: move negentropy to a submodule * chore: add negentropy folder in vendor dir * moved submodule to c-wrapper branch * chore: updated negentropy * chore: udpate submodule URL to use https * chore: started integrating negetropy C wrapper * chore: fixed all compilation errors wrt C-wrapper integration * chore: include sync peers to be returned as part of REST API * chore: tested insert into storage and changes done for it. * chore: experimenting with callback * chore: first test for sync * chore: revert callback changes * chore: revert temp changes * chore: write tests to verify c integration * draft: in progress changes to integrate callback based method from C * chore: in progress callback integration * chore: first working sync example with c bindings * feat: added few tests for sync protocol * chore: copy negentropy so for build to work * chore: add negentropy as dependency for test targets * chore: try to fix CI compilation issue of negentropy * chore: apply suggestions from code review Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> * chore: fix naming convention changes --------- Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> update ref update submodule chore: consider leak fix in negentropy wrapping pointers wrapping pointers clean-up, renaming, wrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Usage of LMDB storage and optimizations would be taken up in a separate PR.
More tests and cleanup and error handling to be taken up as a separate PR.