feat: Postgres partition implementation #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new proc, decreaseDatabaseSize, will have different implementations per each driver. For example, in future commits we will implement a size retention policy thanks for partitions management, in Postgres.
Completing implementation of partition factory and partition deletion. There may still be some bugs that need adjustment.
The new proc, decreaseDatabaseSize, will have different implementations per each driver. For example, in future commits we will implement a size retention policy thanks to partitions management, in Postgres.
…g times.now() times.now() returns time in seconds but we need to be in nanoseconds
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 8aff169 |
Ivansete-status
force-pushed
the
feat-pg-enhancements
branch
from
0732973 to
39183a0
Compare
and retrieve its underlying future object so that it can be cancelled
Ivansete-status
requested review from
SionoiS,
NagyZoltanPeter,
jm-clius and
gabrielmer
6 tasks
NagyZoltanPeter
approved these changes
Mar 6, 2024
SionoiS
approved these changes
Mar 6, 2024
gabrielmer
approved these changes
Mar 6, 2024
| if beginning <= targetMoment and targetMoment < `end`: | ||
| return ok(partition) | ||
|
|
||
| return err("Could'nt find a partition table for given time: " & $targetMoment) |
There was a problem hiding this comment.
Super nitpick 😶
Suggested change
| return err("Could'nt find a partition table for given time: " & $targetMoment) | |
| return err("Couldn't find a partition table for given time: " & $targetMoment) |
There was a problem hiding this comment.
Super nitpick 😶
Thanks! Covered in 62e7b3e
jm-clius
approved these changes
Mar 6, 2024
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all, special thanks to @NagyZoltanPeter for suggesting such a great partition proposal 🥳 !
In this PR we start managing the partition creation and deletion.
This is interesting from the database size maintenance pov.
There will always be a current partition.
The
loopPartitionFactoryproc responsible for making sure that there will always be a future partition available.The
loopPartitionFactorywill check everyDefaultDatabasePartitionCheckTimeInterval(10 minutes hard-coded) whether a new partition should be created or not.The
PartitionsRangeIntervalis also hard-coded (1 hour.) This value establishes the time window to store messaged based in theirstoredAt(epoch time in nanoseconds.)Notice that the partitions are only removed when
sizeretention policy is being applied.Changes
requireon postgres tests. I've noticed that it doesn't handle the failure cases very well.waku/waku_archive/driver/postgres_driver/migrations.nim.)waku/waku_archive/driver/postgres_driver/partitions_manager.nimthat just keeps track the partitions. The partitions are being created from within thepostgres_driver.nim(loopPartitionFactory.) and removed from the size retention policy.postgres_driver.nim. RemovescreateMessageTable,init, anddeleteMessageTableprocs.forceRemoval: bool = falseparam indecreaseDatabaseSizeis for testing purposes, to allow forcing all the partitions.