Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter): log is too large #2665

Merged
merged 1 commit into from
May 3, 2024
Merged

fix(filter): log is too large #2665

merged 1 commit into from
May 3, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 3, 2024

Description

the filter protocol logs out the whole message, this is bad

image

identified this is the offending log -
image

Changes

  • removes the message from the "handling message" filter log

@rymnc rymnc self-assigned this May 3, 2024
Ivansete-status
Ivansete-status approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much! 💯

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2665-rln-v2

Built from 08e4290

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2665-rln-v1

Built from 08e4290

gabrielmer
gabrielmer approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rymnc rymnc merged commit cee020f into master May 3, 2024
15 of 16 checks passed
@rymnc rymnc deleted the fix-log-on-filter branch May 3, 2024 13:35
Ivansete-status pushed a commit that referenced this pull request May 14, 2024
@rymnc @Ivansete-status
fix(filter): log is too large (#2665)
6196552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymnc @gabrielmer @Ivansete-status