chore: waku_discv5, peer_manager - add more logs help debug discovery issues #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
requested review from
chaitanyaprem,
darshankabariya,
gabrielmer,
NagyZoltanPeter and
stubbsta
|
You can find the image built from this PR at Built from 8af6b00 |
|
You can find the image built from this PR at Built from 8af6b00 |
NagyZoltanPeter
approved these changes
May 15, 2024
| return | ||
|
|
||
| if pm.peerStore[AddressBook][remotePeerInfo.peerId] == remotePeerInfo.addrs and | ||
| pm.peerStore[KeyBook][remotePeerInfo.peerId] == remotePeerInfo.publicKey and | ||
| pm.peerStore[ENRBook][remotePeerInfo.peerId].raw.len > 0: | ||
| # Peer already managed and ENR info is already saved | ||
| trace "peer already managed and ENR info is already saved", |
There was a problem hiding this comment.
Not related to this PR...but what if ENR has been updated, in that case do we update the ENR stored and peers capabilities locally?
There was a problem hiding this comment.
Not related to this PR...but what if ENR has been updated, in that case do we update the ENR stored and peers capabilities locally?
The local peer store only gets new entries when a new connections is established
There was a problem hiding this comment.
Ok, where is the ENR record stored for a peer? Is it part of peerStore or somewhere else?
Ivansete-status
force-pushed
the
add-some-more-trace-logs-discv5
branch
from
8a23162 to
ec6a75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more logs to help debugging
discoveryv5issues