fix: invalid cursor returning messages

[SionoiS]

Store v3 queries with invalid cursors will no longer return messages. I also added more/better tests.

Fixing the issue for real this time 💯 % pinky promise, I swear! 🤣

[github-actions]

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2724-rln-v1

Built from 9494293

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2724-rln-v2

Built from 9494293

[gabrielmer]

There's something I don't quite understand. In 3 different tests/files, sending an invalid cursor returns different things.

• In tests/waku_archive/test_driver_postgres_query.nim ok is returned but with no messages
• In tests/waku_archive/test_driver_queue_query.nim the error invalid_cursor is returned
• In tests/waku_archive/test_driver_sqlite_query.nim returns an error with cursor not found

Why the different behavior in those cases? Especially the one that doesn't return an error, I guess that the error message depends on the driver

[SionoiS]

There's something I don't quite understand. In 3 different tests/files, sending an invalid cursor returns different things.

• In tests/waku_archive/test_driver_postgres_query.nim ok is returned but with no messages
• In tests/waku_archive/test_driver_queue_query.nim the error invalid_cursor is returned
• In tests/waku_archive/test_driver_sqlite_query.nim returns an error with cursor not found

Why the different behavior in those cases? Especially the one that doesn't return an error, I guess that the error message depends on the driver

Yes that is a good point that will be addressed by my driver refactor. I plan to consolidate driver error handling.

[gabrielmer]

Thanks so much!

[Ivansete-status]

LGTM! Thanks for it! 💯

[Ivansete-status]

Interesting. Did you need that to avoid a possible crash?

[SionoiS]

I'm not sure. It's just a copy pasta of another test.